fix(notifications): style badge 'attention' if unread danger/warn notifications #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd also store in drawer
andrewazores
force-pushed
the
notification-error-badge
branch
from
a8f789f to
547dec1
Compare
|
Looking good! |
Probably the easiest way is to go to Security and try to upload something that isn't a certificate. I tried uploading a PNG and saw a warning toast. |
jan-law
approved these changes
Aug 27, 2021
This was referenced Aug 31, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254
If danger/warning level graphical notifications are emitted they are "stored" in the notification drawer, and the notification badge on the masthead is updated to the "attention" (red) variant to call the user's focus. Additionally, these notifications (and only these - not the "lower" levels) will be displayed once again as "toast"-style notifications, as they used to be, to help ensure the user notices them in a timely fashion. Closing the toast will mark the notification as read in the drawer as well, but not remove it.
To test, create a recording on a target. Then attempt to create another recording on the same target and using the same recording name.